Merged
Conversation
Andarist
commented
May 29, 2023
| "presets": ["@babel/preset-typescript"], | ||
| "plugins": [ | ||
| "@babel/plugin-proposal-class-properties", | ||
| ["@babel/plugin-proposal-class-properties", { "loose": true }], |
Contributor
Author
There was a problem hiding this comment.
this allows you to skip some Babel helpers from being injected into the output
Andarist
commented
May 29, 2023
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "esModuleInterop": true, | |||
Contributor
Author
There was a problem hiding this comment.
it's best not to use this option when building libraries - it might "taint" the dependency and force all of the consumers to also use this option
Contributor
Author
There was a problem hiding this comment.
This particular package wasn't actually prone to this, so it's fine right now.
Owner
|
Thank you! 🙇🏼 |
Owner
|
I think this change broke the test target: My bad for not having tests run on PRs for this project 💩 |
Contributor
Author
|
I will look into this soon |
Owner
|
This fixes it: diff --git a/jest.config.js b/jest.config.js
index bd9f347..5352e83 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -1,5 +1,15 @@
/** @type {import('ts-jest').JestConfigWithTsJest} */
module.exports = {
+ globals: {
+ "ts-jest": {
+ tsconfig: {
+ allowJs: true,
+ },
+ },
+ },
preset: "ts-jest",
testMatch: ["**/*.test.{ts,tsx}"],
+ transform: {
+ "^.+\\.[tj]sx?$": "ts-jest",
+ },
}; |
Owner
|
Published in 1.0.19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.