Skip to content

Bad performance with Destiny Item Manager site #195

@bvaughn

Description

@bvaughn

This morning I got a report of DevTools performing poorly on the Destiny Item Manager app (facebook/react-devtools#681 (comment))

I think this may be due to props being unexpectedly large (which we send through the bridge and try to render in the right hand side, inspected element panel). Initial Chrome profiling shows us spending a lot of time in this panel.

I think this is made worse because of how we auto-select on hover when using the inspect button, and select triggers us to fetch props- so if you really quickly hover over a lot of items, we ask for all of their props.

I think we may want to do two things:

  1. Re-think our serialization / hydration stuff so we can better handle huge props
  2. Don't send the inspect request on mouse-over for the inspect button mode, but wait until the user clicks and confirms

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions