Skip to content

feat: add red/blue temperature color coding#170

Merged
bvaisvil merged 1 commit intobvaisvil:masterfrom
hamirmahal:feat/red/blue/temperature-color-coding
Dec 4, 2025
Merged

feat: add red/blue temperature color coding#170
bvaisvil merged 1 commit intobvaisvil:masterfrom
hamirmahal:feat/red/blue/temperature-color-coding

Conversation

@hamirmahal
Copy link
Contributor

Closes #169

@hamirmahal hamirmahal force-pushed the feat/red/blue/temperature-color-coding branch from a5000c8 to 0c05d4e Compare November 25, 2025 23:21
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change

Image

@hamirmahal
Copy link
Contributor Author

Without this change

Screenshot from 2025-11-25 15-23-46

Copy link
Owner

@bvaisvil bvaisvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'm curious at how we decide what a set of good thresholds are here.

.join(",");
format!(" TEMP [{t:}°C]")

let hot_threshold = 70_f64;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how these thresholds were determined. I imagine that there is also some processor variety in acceptable temperatures ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point.

https://hone.gg/blog/best-cpu-temperature-for-pc/ shows 40 degrees Celsius on the left, safe side of the spectrum.

https://blog.pcbuilder.net/ideal-cpu-temperature/ says

You should always keep it consistent at 60-70 degrees Celsius; otherwise, the heat may damage your CPU.

While in general use, when you use heavy applications, you should have the temperature of your CPU limited within 40-70 degrees Celsius. This will offer you an extended life span of your CPU.

However, based on the average of 30 distinct processors, the typical normal temperature range is 61 degrees to 73 degrees Celsius.

The secure CPU temperature range for Intel and AMD desktop CPUs is 45-50 degrees Celsius while idle

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think longer term this should be part of a config along with the color choices. But this is fine for now.

@hamirmahal
Copy link
Contributor Author

You're welcome! I left some context at #169 (comment).

@hamirmahal hamirmahal requested a review from bvaisvil December 1, 2025 18:47
@bvaisvil bvaisvil merged commit e132e77 into bvaisvil:master Dec 4, 2025
4 checks passed
@hamirmahal hamirmahal deleted the feat/red/blue/temperature-color-coding branch December 24, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Use intuitive red/blue color coding for temperature

2 participants