Skip to content

Remove unused mut#136

Merged
bvaisvil merged 1 commit intobvaisvil:masterfrom
MilesCranmer:patch-1
Aug 18, 2023
Merged

Remove unused mut#136
bvaisvil merged 1 commit intobvaisvil:masterfrom
MilesCranmer:patch-1

Conversation

@MilesCranmer
Copy link
Contributor

@MilesCranmer MilesCranmer commented Aug 12, 2023

FYI I'm not sure if this is correct or not, but cargo told me to submit this fix:

warning: variable does not need to be mutable
   --> src/metrics/mod.rs:663:17
    |
663 | ...   let mut zd = self.disks.entry(name).or_insert(ZDisk::fro...
    |           ----^^
    |           |
    |           help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
   --> src/metrics/mod.rs:728:13
    |
728 |         let mut overall = self
    |             ----^^^^^^^
    |             |
    |             help: remove this `mut`

@bvaisvil bvaisvil self-assigned this Aug 17, 2023
@bvaisvil
Copy link
Owner

bvaisvil commented Aug 18, 2023

Thanks for the PR. I think it's probably right. The reference does not need to be mutable.

@bvaisvil bvaisvil merged commit 642140e into bvaisvil:master Aug 18, 2023
@MilesCranmer MilesCranmer deleted the patch-1 branch August 19, 2023 04:06
@BrewTestBot BrewTestBot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bvaisvil bvaisvil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MilesCranmer @bvaisvil