sso_proxy: document provider slug configs #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 61.98% 61.84% -0.15%
==========================================
Files 57 57
Lines 4646 4188 -458
==========================================
- Hits 2880 2590 -290
+ Misses 1554 1388 -166
+ Partials 212 210 -2
Continue to review full report at Codecov.
|
b965d1b to
d2e1ee5
Compare
Contributor
|
This is annoying. Do we want to force merge? |
Contributor
Author
|
@jphines Actually, I think that might be a good idea. I've tried to dig into why it's suggesting this change in code coverage, but unclear at the moment. If you're happy with the change, let's force merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some documentation for the upstream configuration option
provider_slug, and the globalsso_proxyDefaultProviderSlugoption is missingSolution
Add in the missing documentation.