sso_*: remove vendored dependencies #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Although we've vendored some dependencies we haven't followed through with a process to continue vendoring and updating them (and are not actively building off of them). This brings confusion when understanding how we use modules, and reduces the benefits we might gain from vendoring in the first place (if only some of our dependencies are properly vendored and up to date)
Solution
Remove vendored dependencies and rely on go modules (
go.mod) to manage and download dependencies.(Alternatively, get a full process in place to properly and regularly vendor all of our dependencies - either way, this PR proposes the former to at least start the ball rolling).
Notes
Go 1.13 will by default use a Google-run Go module proxy and checksum database which will attempt to cache public modules (see https://proxy.golang.org/). Although this won't store them forever, this could be a reasonable middle-ground that still helps alleviate some concerns about dependencies becoming unavailable.
If we wanted to use this module proxy we could also enable the use of it before updating to Go 1.13 (in this PR, for example).