sso_proxy: fix request signer hash panic #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🤦♂ |
e234342 to
2384f7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 62.21% 62.18% -0.03%
==========================================
Files 54 54
Lines 4200 4197 -3
==========================================
- Hits 2613 2610 -3
Misses 1399 1399
Partials 188 188
|
Contributor
Author
|
Rebased and removed |
jphines
approved these changes
Dec 9, 2019
Contributor
Author
|
I think I've said the word 'hash' a few too many times now 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Occasional panics (
http: panic serving 172.17.0.16:49478: d.nx != 0) which seem to be caused bysso_proxyusing the same hasher for multiple requests, creating a race condition between thehasher.Reset()andhasher.Write([]byte(repr))calls.Solution
Instead of storing a
hash.Hashobject within theRequestSigner, instead store a function which creates a newhash.Hash. This lets each request be signed using a different Hash.