sso_proxy: add test for websockets and update docs #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 62.04% 62.04%
=======================================
Files 50 50
Lines 4105 4105
=======================================
Hits 2547 2547
Misses 1370 1370
Partials 188 188 |
benjsto
approved these changes
Oct 10, 2019
Contributor
benjsto
left a comment
There was a problem hiding this comment.
Good test - this will be great to have if/when we do decide to move the hijack to a different handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've recently introduced support for websockets, however we didn't include any tests or documentation updates in the initial pull request.
Solution
Add in a couple of simple tests and documentation updates. Also, the docker golang image that CircleCI uses has been updated to
1.12to bring it in line with SSO's go version (required for websocket support)