sso_proxy: ability to define allowed email address/domain in upstream config #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphines
reviewed
Aug 26, 2019
jphines
reviewed
Aug 26, 2019
8d51b60 to
ec433e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 62.28% 62.37% +0.08%
==========================================
Files 50 50
Lines 4078 4093 +15
==========================================
+ Hits 2540 2553 +13
- Misses 1350 1355 +5
+ Partials 188 185 -3
|
e712880 to
c55aa73
Compare
jphines
previously approved these changes
Sep 4, 2019
244e2c7 to
0703b83
Compare
jphines
previously approved these changes
Sep 4, 2019
7d93f21 to
c8872cd
Compare
c8872cd to
c1af8e0
Compare
pkg:email address validator
c1af8e0 to
4a1ae62
Compare
jphines
approved these changes
Sep 5, 2019
This was referenced Oct 8, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Allowed email addresses and domains can only be specified for SSO as a whole, setting the same restriction on all upstreams. It cannot be set on individual upstreams.
Solution
Allow these variables to be defined in two separate places:
We still expect one of these to be set and will error if neither are.
Notes
Includes small bug fix to both the email address validator and email domain validator packages to avoid mutating the passed in slice, instead opting to create and append to a new one.