docker: build from go 1.12 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 62.23% 62.23%
=======================================
Files 50 50
Lines 4067 4067
=======================================
Hits 2531 2531
Misses 1349 1349
Partials 187 187 |
Contributor
|
Hey @cameronattard. Thanks for sending this through! I’m working on validating this change now. |
Contributor
|
Thanks again for the contribution @cameronattard! |
Jusshersmith
approved these changes
Jul 18, 2019
Contributor
Author
|
Thanks @Jusshersmith. Is there a revised ETA for the next release? |
Contributor
|
Hey @cameronattard - apologies for the delay of this release. We're aiming to release it any day now (by EOD tomorrow most likely), but I'll let you know if that changes. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
httputil.ReverseProxydoesn't support WebSockets in go 1.11.Solution
Build binaries using go 1.12.
Notes
I'm not sure if any additional changes are required to get WebSockets to work, but this is a start.
#103
https://go-review.googlesource.com/c/go/+/146437