Skip to content

Conversation

@Jusshersmith
Copy link
Contributor

Problem

With the introduction of circleci workflows, coverage reports were not being correctly found by the codecov script.

Solution

We persist to workspace further down the flow, after the point in which the test coverage file is created.

Notes

The Codecov script appears to exit gracefully to avoid failing builds - we can alter this behaviour with -Z:

-Z Exit with 1 if not successful. Default will Exit with 0

@Jusshersmith Jusshersmith self-assigned this Jun 28, 2019
@Jusshersmith Jusshersmith merged commit 12dc0fd into master Jun 28, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-fix-code-cov-report branch June 28, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants