Skip to content

ci: introduce circleci workflows #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jusshersmith merged 1 commit into from
Jun 26, 2019
Merged

ci: introduce circleci workflows #220

Jusshersmith merged 1 commit into from
Jun 26, 2019

Conversation

@Jusshersmith
Copy link
Contributor

@Jusshersmith Jusshersmith commented Jun 25, 2019 •
edited
Loading

Problem

There is currently no automation around tagging SSO docker images with the latest tag.

Solution

This PR proposes moving our CircleCI config to use the ‘workflows’ method introduced in CircleCI 2.0, allowing us to better separate and orchestrate individual jobs.

  • Separates circleci jobs into logical ‘workflows’:

    • build
    • push-sso-dev-commit (only runs if build succeeded, and on each commit)
    • push-sso-dev-latest (only runs if build succeeeded, and only on master branch)
    • upload-codecov (only runs if build succeeded)

  • Makefile tasks:

    • new imagepush-latest task (pushes with the latest tag)
    • changes imagepush to imagepush-commit to help separations for circleci
    • adds the latest tag to the image in the releasepush task.

Notes

  • We could also separate the build and test steps.
  • We can solve the problem statement without also moving to the workflows method, but this seemed like a logical advancement

Relevant issues: #193

@Jusshersmith Jusshersmith changed the title ci: introduce circleci workflows [WIP] ci: introduce circleci workflows Jun 25, 2019
@Jusshersmith
Copy link
Contributor Author

Jusshersmith commented Jun 25, 2019

I’m not entirely sure why ci/circleci Expected — Waiting for status to be reported still shows at the moment 🤔

jphines
jphines previously approved these changes Jun 25, 2019
View reviewed changes
@jphines
Copy link
Contributor

jphines commented Jun 25, 2019

Let's get this merged once we understand why the ci/circleci isn't working.

@Jusshersmith
Copy link
Contributor Author

Jusshersmith commented Jun 26, 2019

Why ci/circleci wasn’t working: https://circleci.com/docs/2.0/workflows-waiting-status/

@Jusshersmith Jusshersmith force-pushed the jusshersmith-fix-release-and-tagging-process branch from 084c3f1 to b17f1d6 Compare June 26, 2019 12:11
@Jusshersmith Jusshersmith merged commit da6efae into master Jun 26, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-fix-release-and-tagging-process branch June 26, 2019 12:59
@Jusshersmith Jusshersmith mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jphines jphines jphines approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jusshersmith @jphines