[auth] allow proxying root domains #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphines
approved these changes
Jun 13, 2019
Contributor
|
@cameronattard Thanks for the contribution! |
Contributor
Author
|
My pleasure @jphines. Is there an ETA for the next release? |
Contributor
|
@cameronattard we're planning on creating a formal release at the end of the month. You can pull dev-releases from https://hub.docker.com/r/buzzfeed/sso-dev -- but there is some drift now from latest docs in master to what the latest builds. We're planning on cleaning those up as part of the formal release process. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when users try to proxy requests to a root domain (i.e. not a subdomain of the root domain), they receive a 400 response (invalid redirect parameter). I would like to be able to serve content on my root domains in addition to the subdomains.
Solution
Allow the literal root domain to be a valid redirect URI.