sso_auth: add default provider slug #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jusshersmith
previously approved these changes
Jun 4, 2019
shrayolacrayon
previously approved these changes
Jun 4, 2019
28f4fcc to
14e1e4d
Compare
Jusshersmith
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After some reflection, we should add configuration for a default identity provider with
sso_authto make migrations easier and more seamless.Solution
Add additional configuration for the default provider slug and set up a default identity provider at the path root.
This also fixes
/robots.txtwhich is mistakenly left dangling on the idp slug path.