Skip to content

Conversation

@Jusshersmith
Copy link
Contributor

@Jusshersmith Jusshersmith commented May 13, 2019

Problem

Although config management within SSO is fairly straightforward at the moment, it is also unorganised and doesn't leave much room for extension. Particularly in the sense of multi-provider workflows or for storing the config elsewhere (e.g. remote config). Fulfilling these workflows right now config wise is tricky.

Solution

Implement a new set of methods to manage config variables using a new package dependency such as Viper.
This PR currently introduces back-end changes that allow us to achieve this goal, while retaining functionality and flow (the same things are passed in, and the same things are returned).

Near-future PR's will include further changes to mould the usage of Viper to better fit our needs.

@Jusshersmith Jusshersmith changed the title sso: re-work config management sso: re-work config management [WIP] May 13, 2019
@Jusshersmith Jusshersmith self-assigned this May 16, 2019
@Jusshersmith Jusshersmith changed the title sso: re-work config management [WIP] sso: re-work config management May 17, 2019
@Jusshersmith Jusshersmith force-pushed the jusshersmith-sso-viper branch from 3d71109 to 27c2ec5 Compare May 20, 2019 11:59
@Jusshersmith Jusshersmith changed the title sso: re-work config management sso: introduce Viper for sso config management May 20, 2019
@Jusshersmith Jusshersmith merged commit 59a402c into master May 20, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-sso-viper branch May 20, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants