sso_proxy: refactor hostmux/reverseproxy/tests #187
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SSO up to this point has been structured to share a single provider and oauthproxy instance. This OAuthProxy object did the complex routing, housing various routing types, differentiated different upstreams for authorization, and managed the complexity of switching between various context states.
This, however, adds undue complexity and makes it harder to add more distinct features.
Solution
This is a refactor of the
OAuthProxycode base which emphasizes:hostmustOAuthProxy,UpstreamConfig,Provider, andReverseProxyas opposed to1:N:1:Npreviously.OAuthProxystartup and adding new func option helpers.SSOProxyparent object to house routing,/pingand instantiation of manyOAuthProxyobjects