pkg/logging: resolve timestamp bug #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
9d5304d to
8a8e9bd
Compare
shrayolacrayon
approved these changes
Apr 17, 2019
|
Are there plans to release this change soon? We're very keen to get this out into our deployment to help sort out the timestamps in our logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our timestamp formatting is incorrect in our logging package. This results in a comically incorrect microsecond time being logged.
In
15:04:05.123,1,2,3are identifiers being parsed as month, day, and hour respectively.Fixes #176.
🤦♂️