CI: update dependencies to fix tests #166
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All CI builds are currently failing due to updates to vendored dependencies being required. Specifically, we run
git diffas part of our tests (https://github.com/buzzfeed/sso/blob/master/scripts/test) which fails after the CI process itself tries to update these dependencies.Solution
Update the required dependencies - changes within individual commits outlined below:
Commit f243b66 includes changes to
go.modandgo.sumfrom running https://github.com/buzzfeed/sso/blob/master/Makefile#L18-L20. This is ran during the CI process, which then causes errors in ourgit diffinvocations in https://github.com/buzzfeed/sso/blob/master/scripts/testCommit f58f94f includes changes to local copies of dependencies, from running
go mod vendor(which is ran in https://github.com/buzzfeed/sso/blob/master/scripts/test#L20)I think larger changes are required to this process to keep the CI/test/builds running cleanly, though that can be addressed separately - this PR aims to unblock the CI/build process.