Skip to content

Conversation

@sylr
Copy link

@sylr sylr commented Feb 7, 2019

gpm is totally obsolete so let's move to Go 1.11 and use go mod which is future standard for managing Go dependencies.

@sylr sylr force-pushed the go-1.11 branch 8 times, most recently from dd2981f to 0284a7d Compare February 7, 2019 14:21
@sporkmonger
Copy link
Contributor

Yeah, I've found gpm to be wildly frustrating to work with. I fully support this switch.

@shrayolacrayon
Copy link

Thank you for this contribution @sylr! This is definitely an approach that we want to move towards, however one thing that we'd like to discuss separately is whether or not to check in the vendor'ed dependencies. For the time being to get this merged can you check out the dependencies in this PR?

@sylr
Copy link
Author

sylr commented Feb 7, 2019

@shrayolacrayon I personally prefer to have the libs vendor'ed for two reason:

  • First it's easier for people to build the project when they check it out the first time. They just have to make build and everything should work (minus the tools required like golint and statik). Also if someone messes up its repo (or even delete it) you can still compile.
  • Second when you have libs pinned to a certain version you do not mess with your gopath which can have the same libs but with different versions for other projects.

@jphines
Copy link
Contributor

jphines commented Feb 19, 2019

@sylr if you can rebase this branch -- we'd love to get it in.

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@sylr
Copy link
Author

sylr commented Feb 19, 2019

@jphines done.

@jphines jphines merged commit b63aad4 into buzzfeed:master Feb 19, 2019
@jphines
Copy link
Contributor

jphines commented Feb 19, 2019

@sylr thanks for the contribution! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants