Skip to content

proxy: remove empty cookie from proxy and ignore in signer #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jphines merged 2 commits into from
Jan 18, 2019
Merged

proxy: remove empty cookie from proxy and ignore in signer #143

jphines merged 2 commits into from
Jan 18, 2019

Conversation

@jphines
Copy link
Contributor

@jphines jphines commented Jan 18, 2019

Fixes #142 by

  • Deleting cookie header from the request if empty after removing the session cookie
  • Specify and ignore empty string values in signer

@jphines jphines force-pushed the jhines-remove-empty-cookie branch from de0947d to 9ed2cb3 Compare January 18, 2019 21:48
@jphines jphines merged commit 26fbd09 into master Jan 18, 2019
@jphines jphines deleted the jhines-remove-empty-cookie branch January 18, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@loganmeetsworld loganmeetsworld loganmeetsworld approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jphines @loganmeetsworld