sso-proxy: use internal/pkg/sessions #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aee4fbb to
f432868
Compare
benjsto
reviewed
Jan 9, 2019
| func (ms *MockSessionStore) LoadSession(*http.Request) (*SessionState, error) { | ||
| if ms.Session == nil { | ||
| return nil, http.ErrNoCookie | ||
| } |
Contributor
There was a problem hiding this comment.
pretty trivial but might be cleaner and more concise to to set ms.LoadError to http.ErrNoCookie here?
katzdm
previously approved these changes
Jan 16, 2019
benjsto
previously approved these changes
Jan 16, 2019
9f32476 to
4713a33
Compare
loganmeetsworld
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all session store and csrf store logic to use internal/pkg/sessions.
Fixes #43.
RFR @buzzfeed/infra-security @buzzfeed/sso-maintainers