refactor: SwiftData ModelContext dependencies#79
Merged
Conversation
refactor: breakable model schema v2
buzsh
commented
Mar 8, 2024
buzsh
left a comment
Owner
Author
There was a problem hiding this comment.
Round 2
In review, testing.
…b.com-buzsh:buzsh/SwiftDiffusion into refactor-swiftdata-model-context-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Incompatibility notice:
v0.1-beta.0b1000and earlierDue to changes in the SwiftData model schema, this update will be incompatible with existing databases from
v0.1-beta.0(b1000) and earlier. In the future, I'll implement migration schemes for larger model transitions; however, given that the application is in active development, this would take too much time to do for each independent model transition.Changes
@MainActorlogic for essential model interfacesrootFolder,workspaceFolder.parentrelationship attributes@relationship(deleteRule: .cascade)@Model item:@Attribute deterministicTag: Bool→@Attribute parent: NodeisWorkspaceItemis now determined byworkspaceFolder.containsitem.isWorkspaceItem→workspaceFolder.contains { item }modelContext.delete(item: someItem)→parentFolder.remove(someItem)