Skip to content

Conversation

@MaurUppi
Copy link
Contributor

@MaurUppi MaurUppi commented Aug 1, 2025

✅ What's in the PR:

  1. 🎯 Custom Parameter Feature (commit 8fe185a)
    - 60 files changed, 17,881 insertions, 372 deletions
    - Complete feature implementation with UI components, backend logic, and tests
  2. 📋 Release Documentation (changelog file)
    - Changelog/v2.5.3-release-brief.md
    - Comprehensive feature documentation and user guide

🎯 Feature Overview

Custom Parameter Configuration System, allowing users to configure AI model parameters directly in the UI without code
modification.

TODO

  • Custom Parameter multi-language support. (ONLY English UI currently)

✨ Key Features

  • Zero-code parameter configuration
  • Support for multiple parameter types (String, Float, Boolean, Array, Object, Integer)
  • Real-time validation with error feedback
  • Configuration export/import functionality
  • Comprehensive UI with parameter templates

📋 Changes Include

  • Complete frontend UI components with TypeScript
  • Backend parameter processing and validation
  • IPC handlers for parameter management
  • Comprehensive test coverage
  • Release documentation
  • Removed hard-coded logic: Qwen model provider Thinking mode was hard-coded to be disabled.

🧪 Testing

  • Unit tests for all components
  • Integration tests for parameter processing
  • Demo components for feature showcase

📖 Documentation

  • Release brief: Changelog/v2.5.3-release-brief.md
  • Component documentation included

@vercel
Copy link

vercel bot commented Aug 1, 2025

@web-flow is attempting to deploy a commit to the buxuku's projects Team on Vercel.

A member of the Team first needs to authorize it.

@buxuku
Copy link
Owner

buxuku commented Aug 7, 2025

Thank you very much for your support of this feature. I wonder if it would be convenient for you to further complete the support for multiple languages?

@MaurUppi
Copy link
Contributor Author

MaurUppi commented Aug 8, 2025

Thank you very much for your support of this feature. I wonder if it would be convenient for you to further complete the support for multiple languages?

It's a pretty straightforward feature, and not much description on UI, Float, integer, Arrayetc. seems should not translate to Chinese. What is your opinions?

@buxuku
Copy link
Owner

buxuku commented Aug 11, 2025

I think it should be necessary to maintain consistency among multiple languages
image

Moreover, the JSON Object Editor cannot be edited

image

@MaurUppi
Copy link
Contributor Author

I think it should be necessary to maintain consistency among multiple languages

Moreover, the JSON Object Editor cannot be edited

Noted, I'll fix and enhance it soon.

@MaurUppi
Copy link
Contributor Author

✅ Key Deliverables:

  • 🌍 Full Chinese/English UI: Complete localization with translation files (en/zh parameters.json)
  • 🎨 Clean UI: Fixed duplicate titles, proper provider name display instead of internal IDs
  • 🔧 Simplified Parameters: Removed Object type, supports String/Integer/Float/Boolean/Array only
  • 📝 Updated Changelog: Reflects Object type removal and i18n support
  • 🚀 Production Ready: All builds pass, 22 commits.

Custom Parameter works as expected

  • here is a test against doubao-seed-1-6-250615
  Doubao-Thinking-Enabled.log (Translation service with thinking enabled):
- Lines 20-22: Shows "Custom parameters loaded for provider: openai_1752462191911" with "Body parameters: 1"
- Lines 27-47: Shows full provider config INCLUDING customParameters object with "thinking": "enabled"
- Translation times:
  - Batch 1: Started at 15:45:25, response at 15:46:36 (71 seconds)
  - Batch 2: Started at 15:46:36, response at 15:47:29 (53 seconds)
  - Total: ~124 seconds for 100 subtitles**

  Doubao-Thinking-Disabled.log (Translation service with thinking disabled):
- Lines 20-22: Shows "Custom parameters loaded for provider: openai_1752462191911" with "Body parameters: 1"
- Lines 27-47: Shows full provider config INCLUDING customParameters object with "thinking": "disabled"
- Translation times:
  - Batch 1: Started at 15:50:56, response at 15:51:19 (23 seconds)
  - Batch 2: Started at 15:51:19, response at 15:51:38 (19 seconds)
  - Total: ~42 seconds for 100 subtitles

@buxuku
Copy link
Owner

buxuku commented Aug 18, 2025

There is a conflict in the current branch. Please rebase the main branch and submit again. Thank you very much.

web-flow and others added 18 commits August 18, 2025 15:16
- Fix Boolean validation to show 'Valid' status for both true/false when user interacts
- Remove Object type completely from parameter system to eliminate JSON validation issues
- Add touched state tracking for proper validation timing across all parameter types
- Simplify parameter type options to: String, Integer, Float, Boolean, Array
- Clean up JSON Object Editor logic and related validation code

This resolves critical UX issues where Boolean false values appeared invalid
and eliminates problematic JSON Object validation that was blocking user input.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Add systeminformation dependency for system info features
- Update .gitignore to exclude .specs/ directory
- Lock file updates from dependency changes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Implements comprehensive internationalization for custom parameter components
following existing Chinese/English locale strategy.

Changes:
- Add translation files for parameter namespace (en/zh)
- Update CustomParameterEditor with useTranslation hook
- Update DynamicParameterInput with localized validation messages
- Add parameters namespace to settings and translateControl pages
- Add missing ParameterTemplate interface to fix build

Features:
- All UI text (buttons, tabs, validation, placeholders) now localized
- Graceful fallback to English for missing translations
- Maintains existing parameter functionality and validation
- Follows established next-i18next patterns

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Addresses two UI localization issues:

1. Add provider name support to dialog title
   - Add optional providerName prop to CustomParameterEditor
   - Update title to show "自定义参数配置 - {providerName}" instead of internal ID
   - Fallback to standard title when providerName not provided

2. Fix English text in Chinese UI
   - Replace hardcoded "Initial value for new parameter" with translation key
   - Add tooltips.initialValue to both en/zh translation files
   - Chinese: "新参数的初始值", English: "Initial value for new parameter"

This ensures the custom parameter interface displays properly localized
content in both Chinese and English without any remaining English text
in Chinese UI.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
…arameterEditor

- Fix provider name display by passing providerName={values.name} to CustomParameterEditor
- Replace hardcoded English description with t('customParametersTip') for proper i18n
- Dialog now shows friendly provider name instead of internal ID
- Description displays in Chinese when using Chinese UI

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Remove redundant subtitle text "为此提供商配置自定义头部和请求体参数"
- Cleaner UI with only title showing provider name
- Eliminates duplicate information display

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Replace providerId with values.name in ProviderForm dialog title
- Remove duplicate title section from CustomParameterEditor component
- Remove unused providerName prop and parameter
- Dialog now shows: "自定义参数配置 - 火山引擎-Doubao" instead of internal ID
- Clean single title display eliminates UI duplication

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Remove Object type from supported parameter types list
- Update Array description to be more accurate
- Add comprehensive internationalization support section
- Document Chinese/English UI support
- Add language adaptation information to migration notes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@MaurUppi MaurUppi force-pushed the feature/custom-parameter-pr branch from 48a1380 to 5dd8ea0 Compare August 18, 2025 07:17
@buxuku buxuku merged commit fc65d82 into buxuku:main Aug 18, 2025
1 check failed
@MaurUppi
Copy link
Contributor Author

There is a conflict in the current branch. Please rebase the main branch and submit again. Thank you very much.

Hi! I've rebased the branch onto the latest main. The conflicts should now be resolved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants