Skip to content

SwiftPM Quick dependency fix#309

Merged
pcantrell merged 2 commits intomasterfrom
swiftpm-quick-dependency-fix
Apr 10, 2020
Merged

SwiftPM Quick dependency fix#309
pcantrell merged 2 commits intomasterfrom
swiftpm-quick-dependency-fix

Conversation

@pcantrell
Copy link
Copy Markdown
Member

@pcantrell pcantrell commented Apr 10, 2020

Siesta currently fails when added as a SwiftPM dependency using a version number instead of a branch (see #308), because:

  • Siesta uses an unmerged feature branch on a fork of Quick,
  • Siesta specifies that branch instead of a version number in its dependency on Quick,
  • SwiftPM doesn’t allow a versioned dependency (e.g. “Siesta ≥1.5.0”) to have a branch-based dependency, and
  • SwiftPM doesn’t know how to ignore test-only targets of dependencies.

This PR fixes the issue by using a newly created ad hoc version number for the pcantrell fork of Quick until Quick/Quick#820 is merged.

@pcantrell pcantrell merged commit cb9c1bf into master Apr 10, 2020
@pcantrell pcantrell deleted the swiftpm-quick-dependency-fix branch April 10, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant