Fix SiestaUI library for Swift Package Manager#301
Merged
pcantrell merged 1 commit intobustoutsolutions:masterfrom Mar 6, 2020
Merged
Fix SiestaUI library for Swift Package Manager#301pcantrell merged 1 commit intobustoutsolutions:masterfrom
pcantrell merged 1 commit intobustoutsolutions:masterfrom
Conversation
Contributor
karlshea
commented
Jan 10, 2020
- SiestaUI library product/target added
- Copy Collection extension into SeistaUI source, fixing an "inaccessable due to 'internal' protection level" error while building
Member
|
Thanks for taking this on, @karlshea! Tested locally and it works great! Two questions before I merge:
|
Contributor
Author
|
I'm not sure about the answers to either of those—I was using Siesta in my first iOS project so I've been learning as I go. Maybe it would be best to keep this as a PR until someone that really knows the right way to package something for Swift PM can weigh in on the best direction. |
Member
|
I think I’ll merge this so that people can at least use SwiftPM with Siesta, and patch up later (or least investigate to my satisfaction) before cutting an official release. |
Member
|
Official word from the SwiftPM maintainers themselves:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.