Conversation
Repeatedly altering just a URL is more efficient than repeatedly creating and discarding resources.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Siesta currently requires you to call
withParamfor each individual parameter you want to add to a resource:This PR adds the ability to pass a dictionary of many parameters at once:
This has some arguable readability benefit, and can make it easier to build query strings whose keys vary dynamically.
It also has some performance benefit when adding many parameters, since it does not require the creation of intermediate
Resourceobjects at each step — though the benefit is small, on the order of tens of microseconds per param.