Fix cancelLoadIfUnobserved(afterDelay), taking the delay into account#279
Merged
pcantrell merged 3 commits intobustoutsolutions:masterfrom Sep 30, 2018
Merged
Conversation
Member
|
Ha, I’ll be darned! Thanks for catching this. I’d be tempted to say that this is too small a thing to test, except … I screwed it up, so obviously it isn’t! I worry a little about writing timing-dependent tests like this: Travis is so slow and timings are so inconsistent, timing-dependent things like this can make CI sporadically fail. (Siesta’s already in that boat with waiting for Nocilla cleanup, and it's not great.) But I think your testing approach is good, so I’ll merge it and if it breaks CI we can add slop to the tests later. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, the delay passed to cancelLoadIfUnobserved(afterDelay) was not used (a value of 0.05 seconds was fixed).
Added new tests.