Simple obfuscation for large literals#720
Merged
mvdan merged 2 commits intoburrowers:masterfrom Apr 30, 2023
Merged
Conversation
mvdan
approved these changes
Apr 29, 2023
Member
mvdan
left a comment
There was a problem hiding this comment.
Thanks for the patch! Just some minor stuff.
FYI @lu4p if you have any thoughts.
Contributor
Author
|
attempt no. 2 var x = ""
func init() {
x += "first_string"
x += "second_string"
...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes literal obfuscation such that literals of any size will be obfuscated, but beyond
maxSizewe only use the simple obfuscator. This one seems to apply one of the AND, OR or XOR operators byte-wise and should be safe to use.The test for literals is changed a bit to verify that obfuscation is applied. The code written to the
extra_literals.gofile by the test helper now creates aninitfunction withPrintfstatements inside. This way Go does not optimize the literals away when we compile. We also append a unique string to all literals so that we can test that an unobfuscated build contains this string while an obfuscated build does not.