Skip to content

test(add): stabilize from-env env-var tests#11

Merged
burakdede merged 2 commits intomainfrom
fix/add-env-test-flake
Apr 18, 2026
Merged

test(add): stabilize from-env env-var tests#11
burakdede merged 2 commits intomainfrom
fix/add-env-test-flake

Conversation

@burakdede
Copy link
Copy Markdown
Owner

@burakdede burakdede commented Apr 18, 2026

Summary

  • serialize env-var mutation in commands::add from-env tests with a dedicated test mutex
  • restore env var values via guard drop to avoid leakage across tests
  • eliminate race causing intermittent from_env_unset_errors failure on CI

Verification

  • cargo test commands::add::tests::from_env_ -- --nocapture
  • repeated from_env_unset_errors run (50x) passed locally

@burakdede burakdede merged commit e808e55 into main Apr 18, 2026
5 checks passed
@burakdede burakdede deleted the fix/add-env-test-flake branch April 18, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant