fix: don't abort previous package's onSuccess in workspace builds (#118)

arshad-yaseen · web-flow · commit a6ab280d7efc · 2026-02-27T22:43:37.000+05:30
diff --git a/packages/bunup/src/build.ts b/packages/bunup/src/build.ts
@@ -47,19 +47,14 @@ import { cleanOutDir, getFilesFromGlobs, isJavascriptFile } from "./utils/file";
 import { formatListWithAnd } from "./utils/format";
 import { cleanPath } from "./utils/path";
 
-let ac: AbortController | null = null;
-
 export async function build(
 	userOptions: Partial<BuildOptions>,
 	rootDir: string = process.cwd(),
+	ac?: AbortController,
 ): Promise<BuildResult> {
 	ensureMinimumBunVersion();
 
-	if (ac) {
-		ac.abort();
-	}
-
-	ac = new AbortController();
+	const localAc = ac ?? new AbortController();
 
 	const options = resolveBuildOptions(userOptions);
 
@@ -221,17 +216,22 @@ export async function build(
 		!options.compile
 	) {
 		try {
-			const { entry, splitting, resolve: userDtsResolve, ...dtsOptions } =
-				typeof options.dts === "object" ? options.dts : {};
+			const {
+				entry,
+				splitting,
+				resolve: userDtsResolve,
+				...dtsOptions
+			} = typeof options.dts === "object" ? options.dts : {};
 
 			const bundledDeps = getBundledDepsForDtsResolve(options, packageJson.data);
-			const dtsResolve = userDtsResolve === false
-				? false
-				: !bundledDeps?.length
-				? userDtsResolve
-				: userDtsResolve === true
-					? true
-					: [...bundledDeps, ...(Array.isArray(userDtsResolve) ? userDtsResolve : [])];
+			const dtsResolve =
+				userDtsResolve === false
+					? false
+					: !bundledDeps?.length
+						? userDtsResolve
+						: userDtsResolve === true
+							? true
+							: [...bundledDeps, ...(Array.isArray(userDtsResolve) ? userDtsResolve : [])];
 
 			const dtsResult = await generateDts(ensureArray(entry ?? entrypoints), {
 				cwd: rootDir,
@@ -301,7 +301,7 @@ export async function build(
 	});
 
 	if (options.onSuccess) {
-		await executeOnSuccess(options.onSuccess, options, ac.signal);
+		await executeOnSuccess(options.onSuccess, options, localAc.signal);
 	}
 
 	logger.log("");
diff --git a/packages/bunup/src/watch.ts b/packages/bunup/src/watch.ts
@@ -40,6 +40,7 @@ export async function watch(
 	let isRebuilding = false;
 	let buildCount = 0;
 	let lastChangedFile: string | undefined;
+	let ac: AbortController | null = null;
 
 	const triggerRebuild = async (initial: boolean, changed?: string) => {
 		if (isRebuilding) {
@@ -68,9 +69,15 @@ export async function watch(
 				);
 			}
 
+			if (ac) {
+				ac.abort();
+			}
+
+			ac = new AbortController();
+
 			const start = performance.now();
 
-			const buildResult = await build(userOptions, rootDir);
+			const buildResult = await build(userOptions, rootDir, ac);
 
 			await printBuildReport(buildResult);
 
diff --git a/packages/bunup/test/bunup.config.ts b/packages/bunup/test/bunup.config.ts
@@ -2,5 +2,5 @@ import { defineConfig } from "../src";
 
 export default defineConfig({
 	entry: ["fixtures/main.ts"],
-	noExternal: ["ora"]
+	noExternal: ["ora"],
 });
diff --git a/packages/bunup/test/fixtures/main.ts b/packages/bunup/test/fixtures/main.ts
@@ -1,3 +1,3 @@
 import { type Color } from "ora";
 
-export type {Color};
+export type { Color };

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`import { type Color } from "ora";`
`2`	`2`
`3`		`-export type {Color};`
	`3`	`+export type { Color };`