fix: packages option not respecting external/noExternal

arshad-yaseen · arshad-yaseen · commit 690cee51cf6b · 2026-02-08T00:37:48.000+05:30
diff --git a/packages/bunup/src/build.ts b/packages/bunup/src/build.ts
@@ -127,7 +127,6 @@ export async function build(
 				env: resolvedEnv,
 				ignoreDCEAnnotations: options.ignoreDCEAnnotations,
 				emitDCEAnnotations: options.emitDCEAnnotations,
-				packages: options.packages,
 				jsx: options.jsx,
 				// @ts-expect-error - compile option is a different interface in Bun.build api, but it's valid as is
 				compile: options.compile,
diff --git a/packages/bunup/src/helpers/external.ts b/packages/bunup/src/helpers/external.ts
@@ -1,8 +1,8 @@
 import type { BuildOptions } from "../options";
-import { getPackageDeps } from "../utils/package";
+import { getPackageExternalDeps, getPackageAllDeps } from "../utils/package";
 
-function getPackageDepsPatterns(packageJson: Record<string, unknown> | null): RegExp[] {
-	return getPackageDeps(packageJson).map((dep) => new RegExp(`^${dep}($|\\/|\\\\)`));
+function getDepsPatterns(deps: string[]): RegExp[] {
+	return deps.map((dep) => new RegExp(`^${dep}($|\\/|\\\\)`));
 }
 
 function matchesPattern(path: string, pattern: string | RegExp): boolean {
@@ -14,7 +14,8 @@ export function isExternalFromPackageJson(
 	options: BuildOptions,
 	packageJson: Record<string, unknown> | null,
 ): boolean | undefined {
-	const packageDepsPatterns = getPackageDepsPatterns(packageJson);
+	const packageExternalDepsPatterns = getDepsPatterns(getPackageExternalDeps(packageJson));
+	const packageAllDepsPatterns = getDepsPatterns(getPackageAllDeps(packageJson));
 
 	if (options.packages === "bundle") {
 		const explicitlyExternal = options.external?.some((pattern) => matchesPattern(path, pattern));
@@ -28,11 +29,11 @@ export function isExternalFromPackageJson(
 			return false;
 		}
 
-		return packageDepsPatterns.some((pattern) => pattern.test(path));
+		return packageAllDepsPatterns.some((pattern) => pattern.test(path));
 	}
 
 	const matchesExternalPattern =
-		packageDepsPatterns.some((pattern) => pattern.test(path)) ||
+		packageExternalDepsPatterns.some((pattern) => pattern.test(path)) ||
 		options.external?.some((pattern) => matchesPattern(path, pattern));
 
 	const isExcludedFromExternal = options.noExternal?.some((pattern) =>
diff --git a/packages/bunup/src/utils/package.ts b/packages/bunup/src/utils/package.ts
@@ -1,4 +1,4 @@
-export function getPackageDeps(packageJson: Record<string, unknown> | null): string[] {
+export function getPackageExternalDeps(packageJson: Record<string, unknown> | null): string[] {
 	if (!packageJson) return [];
 
 	return Array.from(
@@ -8,3 +8,15 @@ export function getPackageDeps(packageJson: Record<string, unknown> | null): str
 		]),
 	);
 }
+
+export function getPackageAllDeps(packageJson: Record<string, unknown> | null): string[] {
+	if (!packageJson) return [];
+
+	return Array.from(
+		new Set([
+			...Object.keys(packageJson.dependencies || {}),
+			...Object.keys(packageJson.devDependencies || {}),
+			...Object.keys(packageJson.peerDependencies || {}),
+		]),
+	);
+}
diff --git a/packages/bunup/test/bunup.config.ts b/packages/bunup/test/bunup.config.ts
@@ -1,5 +1,5 @@
 import { defineConfig } from "../src";
 
 export default defineConfig({
-	entry: ["fixtures/nice/index.ts"],
+	entry: ["fixtures/main.ts"],
 });
diff --git a/packages/bunup/test/fixtures/main.ts b/packages/bunup/test/fixtures/main.ts
@@ -1,3 +1,3 @@
-import { fetch } from "undici";
+import { spinners } from "ora";
 
-fetch("");
+export { spinners };
diff --git a/packages/bunup/test/fixtures/nice/index.ts b/packages/bunup/test/fixtures/nice/index.ts
diff --git a/packages/bunup/test/specs/utils.test.ts b/packages/bunup/test/specs/utils.test.ts
@@ -9,7 +9,7 @@ import {
 } from "../../src/utils/extension";
 import { cleanOutDir, isGlobPattern } from "../../src/utils/file";
 import { formatFileSize } from "../../src/utils/format";
-import { getPackageDeps } from "../../src/utils/package";
+import { getPackageAllDeps, getPackageExternalDeps } from "../../src/utils/package";
 import { cleanPath, getShortFilePath } from "../../src/utils/path";
 
 describe("Utils", () => {
@@ -58,16 +58,30 @@ describe("Utils", () => {
 		});
 	});
 
-	describe("getPackageDeps", () => {
+	describe("getPackageExternalDeps", () => {
 		it("returns dependencies and peerDependencies", () => {
 			const packageJson = {
 				dependencies: { dep1: "1.0.0" },
 				peerDependencies: { peerDep1: "^2.0.0" },
 			};
-			expect(getPackageDeps(packageJson)).toEqual(["dep1", "peerDep1"]);
+			expect(getPackageExternalDeps(packageJson)).toEqual(["dep1", "peerDep1"]);
 		});
 		it("returns empty array for no dependencies", () => {
-			expect(getPackageDeps(null)).toEqual([]);
+			expect(getPackageExternalDeps(null)).toEqual([]);
+		});
+	});
+
+	describe("getPackageAllDeps", () => {
+		it("returns dependencies, devDependencies, and peerDependencies", () => {
+			const packageJson = {
+				dependencies: { dep1: "1.0.0" },
+				devDependencies: { dep1: "^1.1.0", devDep1: "^2.0.0" },
+				peerDependencies: { peerDep1: "^3.0.0" },
+			};
+			expect(getPackageAllDeps(packageJson)).toEqual(["dep1", "devDep1", "peerDep1"]);
+		});
+		it("returns empty array for no dependencies", () => {
+			expect(getPackageAllDeps(null)).toEqual([]);
 		});
 	});
 
