Skip to content

Support for TravisCI push branch name#95

Merged
iamogbz merged 2 commits into
bundlewatch:masterfrom
cropio:fix/support-travis-ci-push-branch-name
Apr 26, 2020
Merged

Support for TravisCI push branch name#95
iamogbz merged 2 commits into
bundlewatch:masterfrom
cropio:fix/support-travis-ci-push-branch-name

Conversation

@oleksii-leonov

@oleksii-leonov oleksii-leonov commented Mar 22, 2020

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Fix #69.

Did you add tests for your changes?

There is no specific spec file for different CI systems env configurations right now.
Could add specs if required. However, this change is quite trivial.

If relevant, link to documentation update:

N/A

Summary

TRAVIS_PULL_REQUEST_BRANCH empty for push-triggered builds (after PR merged to master).
Make sense to use TRAVIS_BRANCH env in this case.

Fix #69.

Does this PR introduce a breaking change?

No.

Other information

@oleksii-leonov
Support for TravisCI push branch name
0931ed0 
Fix bundlewatch#69.

`TRAVIS_PULL_REQUEST_BRANCH` empty for push-triggered builds (when PR was merged to `master`).
Make sense to use `TRAVIS_BRANCH` env in this case.
@oleksii-leonov
Merge branch 'master' into fix/support-travis-ci-push-branch-name
bc1fbb0
@oleksii-leonov

oleksii-leonov commented Mar 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CircleCI passed, however, bundlewatch report can't be sent:

[WARNING] Some CI configuration options were not found (githubAccessToken):
    bundlewatch will be unable to report build status, or save comparison data
    Learn more at: https://bundlewatch.io/
        
Result breakdown at: https://ja2r7.app.goo.gl/M3Gcr7J1iwq9hEmR9

PASS ./__testdata__/test-file-1.jpg: 68.82KB < 500KB (no compression)
PASS ./__testdata__/test-file-2.jpg: 449.79KB < 500KB (no compression)
PASS ./lib/app/analyze/analyze.test.mockdata.js: 229B < 2KB (gzip)
PASS ./lib/app/analyze/analyzeFiles/index.js: 938B < 2KB (gzip)
PASS ./lib/app/analyze/index.js: 976B < 2KB (gzip)
PASS ./lib/app/config/ensureValid.js: 924B < 2KB (gzip)
PASS ./lib/app/config/getCIVars.js: 843B < 2KB (gzip)
PASS ./lib/app/config/getConfig.js: 558B < 2KB (gzip)
PASS ./lib/app/errors/ValidationError.js: 175B < 2KB (gzip)
PASS ./lib/app/getLocalFileDetails/getSize.js: 604B < 2KB (gzip)
PASS ./lib/app/getLocalFileDetails/index.js: 599B < 2KB (gzip)
PASS ./lib/app/index.js: 1.35KB < 2KB (gzip)
PASS ./lib/app/reporting/BundleWatchService/index.js: 887B < 2KB (gzip)
PASS ./lib/app/reporting/GitHubService/index.js: 1017B < 2KB (gzip)
PASS ./lib/app/resultsPage/createURL.js: 786B < 2KB (gzip)
PASS ./lib/app/resultsPage/shortenURL.js: 578B < 2KB (gzip)
PASS ./lib/bin/determineConfig.js: 985B < 2KB (gzip)
PASS ./lib/bin/index.js: 1.37KB < 2KB (gzip)
PASS ./lib/logger/index.js: 561B < 2KB (gzip)
PASS ./artifacts/bundlewatch-0.0.0.tgz: 10.7KB < 15KB (gzip)

bundlewatch PASS
Everything is in check (+542.45KB, -0B)

iamogbz
iamogbz approved these changes Apr 26, 2020
View reviewed changes

@iamogbz iamogbz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamogbz iamogbz merged commit 1ae2e72 into bundlewatch:master Apr 26, 2020
@iamogbz

iamogbz commented Apr 26, 2020

Copy link
Copy Markdown
Member

@all-contributors please add @aleksejleonov for code

@allcontributors allcontributors Bot mentioned this pull request Apr 26, 2020
Merged
@allcontributors

allcontributors Bot commented Apr 26, 2020

Copy link
Copy Markdown
Contributor

@iamogbz

I've put up a pull request to add @aleksejleonov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamogbz iamogbz iamogbz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

https://service.bundlewatch.io/store failed with status code 404

2 participants

@oleksii-leonov @iamogbz