chore: fix CircleCI steps not passing exit codes properly#447
Merged
Conversation
0807866 to
96046a3
Compare
96046a3 to
28e785d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixed a bug where exit codes weren't correctly passed to CircleCI.
Did you add tests for your changes?
Those are changing tests.
If relevant, link to documentation update:
N/A
Summary
We had 3 failed tests but CircleCI was still green because we weren't passing the exit codes properly.
Added
-eo pipefailto the shell and I had to remove tests for GitHub Actions as we have issues testing them on CI because of the environment variables. Also, they were just testingci-env, we should create better tests that will mock the expected environment.Does this PR introduce a breaking change?
No.
Other information