fix: main does not reflect index.js location#33
Merged
Conversation
Contributor
Author
|
Actually this is wrong all together. I don't see where the index.js is for the API? there's the app and there's the bin folder, but no where is there anything for the api in particular. Both those other folders make assumptions :/ |
Member
|
@Aghassi haven't looked in a while. I think this is it: https://github.com/bundlewatch/bundlewatch/blob/master/src/app/index.js You can see the bin using it: https://github.com/bundlewatch/bundlewatch/blob/master/src/bin/index.js#L43 |
iamogbz
reviewed
Mar 11, 2020
iamogbz
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes the NodeJS API import since the main is the incorrect path
Did you add tests for your changes?
Nope :/
If relevant, link to documentation update:
Summary
I want to use the Node API, but the main in package.json doesn't reflect the proper place to grab the import from.
Does this PR introduce a breaking change?
Nope, it fixes one though.
Other information