fix: file path normalization wasn't working right#238
Merged
Conversation
Signed-off-by: Chang Wang <garnwraly@gmail.com>
Signed-off-by: Chang Wang <garnwraly@gmail.com>
f190523 to
dcc7671
Compare
jakebolam
approved these changes
Sep 22, 2020
Member
|
@cheapsteak thank you 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, link to documentation update:
Summary
following up to #214
We're currently generating confusing reports where the file names show up as the same but they're not compared against their previous version
It looks like we needed to perform normalization earlier than when
analyzewas called, since there's a call tobundlewatchService.saveFileDetailsForCurrentBranchbeforeanalyzeis runbundlewatch/src/app/index.js
Lines 31 to 42 in 57c71de
Does this PR introduce a breaking change?
No, the API is kept the same as before (any captured segments are removed)
Other information