feat: Allow filepaths in reports to be normalized (e.g. remove content hashes)#192
Closed
cheapsteak wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@jakebolam poke 🙏 |
|
@jakebolam Any update on this? |
|
+1 @jakebolam |
Member
|
This is a great feature! Lets see if we can get it in |
Member
|
Closing in favour of #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This addresses #30 to allow file paths in reports be processed (mainly to normalize hashes)
bundlewatch/src/app/index.test.js
Lines 115 to 116 in 3c2c49a
Since both the pattern and replacement are passed in, this config makes no assumptions about where hashes exists in the path
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
Summary
Motivation is summarized pretty well in #30
Bundle often contain hashes in the path name, not being able to compare across versions of the same file cripples the usefulness of the file size watcher
Does this PR introduce a breaking change?
No