Issue #553: Add AndroidX ViewModel integration as separate module#598
Closed
Al-F wants to merge 16 commits intobumble-tech:2.xfrom
Closed
Issue #553: Add AndroidX ViewModel integration as separate module#598Al-F wants to merge 16 commits intobumble-tech:2.xfrom
Al-F wants to merge 16 commits intobumble-tech:2.xfrom
Conversation
...el/src/main/kotlin/com/bumble/appyx/utils/viewmodel/ActivityIntegrationPointWithViewModel.kt
Fixed
Show fixed
Hide fixed
utils/viewmodel/src/main/kotlin/com/bumble/appyx/utils/viewmodel/sample/MyViewModel.kt
Fixed
Show fixed
Hide fixed
utils/viewmodel/src/main/kotlin/com/bumble/appyx/utils/viewmodel/IntegrationPointViewModel.kt
Fixed
Show fixed
Hide fixed
...el/src/main/kotlin/com/bumble/appyx/utils/viewmodel/ActivityIntegrationPointWithViewModel.kt
Outdated
Show resolved
Hide resolved
utils/viewmodel/src/main/kotlin/com/bumble/appyx/utils/viewmodel/IntegrationPointViewModel.kt
Outdated
Show resolved
Hide resolved
| import androidx.lifecycle.viewModelScope | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class MyViewModel : IntegrationPointViewModel() { |
Collaborator
There was a problem hiding this comment.
Let's move it to samples otherwise this code will be shipped
Collaborator
There was a problem hiding this comment.
Additionally, let's create a proper sample in the demo modules
utils/viewmodel/src/main/kotlin/com/bumble/appyx/utils/viewmodel/node/ViewModelNode.kt
Outdated
Show resolved
Hide resolved
...el/src/main/kotlin/com/bumble/appyx/utils/viewmodel/ActivityIntegrationPointWithViewModel.kt
Outdated
Show resolved
Hide resolved
...el/src/main/kotlin/com/bumble/appyx/utils/viewmodel/ActivityIntegrationPointWithViewModel.kt
Outdated
Show resolved
Hide resolved
...navigation/android/src/main/kotlin/com/bumble/appyx/navigation/node/viewModel/MyViewModel.kt
Outdated
Show resolved
Hide resolved
...ewmodel-android/src/main/kotlin/com/bumble/appyx/utils/viewmodel/node/ViewModelParentNode.kt
Fixed
Show fixed
Hide fixed
zsoltk
reviewed
Oct 13, 2023
...ewmodel-android/src/main/kotlin/com/bumble/appyx/utils/viewmodel/node/ViewModelParentNode.kt
Outdated
Show resolved
Hide resolved
| lifecycle = AndroidLifecycle(LocalLifecycleOwner.current.lifecycle), | ||
| integrationPoint = appyxV2IntegrationPoint, | ||
| ) { | ||
| node(buildContext = it) { modifier -> |
Collaborator
There was a problem hiding this comment.
I think we should create an example where we use ViewModelNode
...n/android/src/main/kotlin/com/bumble/appyx/navigation/node/viewModel/ViewModelNodeExample.kt
Fixed
Show fixed
Hide fixed
25a0dba to
7206271
Compare
| @ExperimentalAnimationApi | ||
| @ExperimentalComposeUiApi | ||
| class MainActivity : NodeActivity() { | ||
| class MainActivity : ViewModelNodeActivity() { |
Collaborator
There was a problem hiding this comment.
I should revert this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
...
Check list
CHANGELOG.mdif required.