Skip to content

Add support for 'paths' in configuration to allow one to search for scheduler binary in non-standard location#1757

Merged
shahzebsiddiqui merged 24 commits intodevelfrom
paths_for_sched_libs_in_configuration
Apr 19, 2024
Merged

Add support for 'paths' in configuration to allow one to search for scheduler binary in non-standard location#1757
shahzebsiddiqui merged 24 commits intodevelfrom
paths_for_sched_libs_in_configuration

Conversation

@shahzebsiddiqui
Copy link
Member

This PR will attempt to add the following keys in configuration file where one can specify an alternate location where to search for scheduler binaries that can be useful if they are not in $PATH

    paths:
      lsf: "/usr/local/bin"
      slurm: "/usr/local/bin"
      pbs: "/usr/local/bin"
      cobalt: "/usr/local/bin"
      torque: "/usr/local/bin"

some of the keys that it can be declared are 'pbs', 'torque', 'lsf', 'slurm', 'cobalt' for specifying
directory paths where to search for binaries.
…hich will be a list of colon separated list of directory

paths where to search for binaries
binary paths as a dictionary. An optional argument custom_dirs can be
used to search for binary in additional paths that will be appended to
PATH
needed. We are doing this check later in SiteConfiguration class
method from the class
Change Torque class to be subclass of Scheduler instead of PBS and make
use of custom_dirs to properly detect the binary paths.

We have changed logic on how to determine a scheduler is active
shahzebsiddiqui and others added 13 commits April 18, 2024 19:42
in the if condition since we still want to poll them and they will be
cancelled once maxpendtime is reached
For sleep_cancel job we will hold the job so it cancels
job
also forgot to call method retrieve_jobdata  in gather method for
SlurmExecutor class which is needed to get the job data used for
detecting the exitcode
remove unnecessary return statement that caused issue with cobalt job to
not cancel job since return value was None
…nstall we needed to add option to wget --no-check-certificate

to get the script to install.
We updated the example buildspecs for pbs tests
change logic for when to retrieve get_queues method for PBS and Torque only if check method pass
@shahzebsiddiqui shahzebsiddiqui merged commit 50deac0 into devel Apr 19, 2024
@shahzebsiddiqui shahzebsiddiqui deleted the paths_for_sched_libs_in_configuration branch April 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant