Improvement to Scheduler Detection and improve logging for executor validation#1742
Merged
shahzebsiddiqui merged 11 commits intodevelfrom Apr 2, 2024
Merged
Conversation
eliminate reuse of code. We have refactor Slurm class by creating method to run arbitrary slurm queues to get information like qos, partition and clusters.
make use of various helper methods used to get queue details
will be used in validation of slurm executors
add method validate_qos in Slurm class
class this is done outside of class
…ation and moving this logic out of SiteConfiguration class. Also remove commented out code
and additional output useful for debugging executor validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.