Skip to content

add support for regular expression types (re.search, re.match, re.fullmatch) in status check and metrics definition#1730

Merged
shahzebsiddiqui merged 14 commits intodevelfrom
specify_regex_type
Mar 16, 2024
Merged

add support for regular expression types (re.search, re.match, re.fullmatch) in status check and metrics definition#1730
shahzebsiddiqui merged 14 commits intodevelfrom
specify_regex_type

Conversation

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented Mar 15, 2024

@Xiangs18 in case you start working on #1725 just be on lookout for this PR, you might get a merge conflict when you start working so just rebase

…rics definition

which allows one to select one of the regular expression types re.search, re.match or re.fullmatch
Added an example buildspec and implementation for status check with different regular expression
when using regex and file_regex field under status check
@codecov
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.85%. Comparing base (2d1d74a) to head (17d9f74).
Report is 16 commits behind head on devel.

Files Patch % Lines
buildtest/builders/base.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1730      +/-   ##
==========================================
+ Coverage   80.81%   80.85%   +0.03%     
==========================================
  Files          57       57              
  Lines        6432     6453      +21     
==========================================
+ Hits         5198     5217      +19     
- Misses       1234     1236       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahzebsiddiqui shahzebsiddiqui merged commit 44e9da7 into devel Mar 16, 2024
@shahzebsiddiqui shahzebsiddiqui deleted the specify_regex_type branch March 16, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant