Skip to content

remove executors via command line 'buildtest config executors remove'#1636

Merged
shahzebsiddiqui merged 7 commits intodevelfrom
remove_executors
Oct 3, 2023
Merged

remove executors via command line 'buildtest config executors remove'#1636
shahzebsiddiqui merged 7 commits intodevelfrom
remove_executors

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

This will autocomplete with list of executors that are available to be removed
… executors

add option 'buildtest config executors list --all' to list all executors available
add support for removing executors.
…r defined. This will

prevent issue during validation where removing an executor leads to no local executors`
@shahzebsiddiqui shahzebsiddiqui linked an issue Oct 2, 2023 that may be closed by this pull request
2 tasks
add test coverage for listing all executors.
fix issue with method invocation for remove_executors
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7691771) 78.43% compared to head (f2b7133) 78.45%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1636      +/-   ##
==========================================
+ Coverage   78.43%   78.45%   +0.03%     
==========================================
  Files          57       57              
  Lines        6647     6683      +36     
==========================================
+ Hits         5213     5243      +30     
- Misses       1434     1440       +6     
Files Coverage Δ
buildtest/cli/__init__.py 97.60% <ø> (ø)
buildtest/config.py 52.36% <87.50%> (+1.38%) ⬆️
buildtest/cli/config.py 85.83% <82.14%> (-1.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ecutors.

add test coverage when there is an invalid executor type and executor name
@shahzebsiddiqui shahzebsiddiqui merged commit 4559890 into devel Oct 3, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the remove_executors branch October 3, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: add support for removing executors from configuration file

1 participant