Skip to content

Added support to deactivate spack environments#1587

Merged
shahzebsiddiqui merged 27 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch
Aug 16, 2023
Merged

Added support to deactivate spack environments#1587
shahzebsiddiqui merged 27 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch

Conversation

@Mariamajib
Copy link
Collaborator

@Mariamajib Mariamajib commented Aug 9, 2023

@Mariamajib Mariamajib self-assigned this Aug 9, 2023
@Mariamajib Mariamajib linked an issue Aug 9, 2023 that may be closed by this pull request
6 tasks
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 9, 2023
@Mariamajib Mariamajib marked this pull request as ready for review August 9, 2023 20:22
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (c828d11) 78.38% compared to head (7e98c97) 78.24%.
Report is 50 commits behind head on devel.

❗ Current head 7e98c97 differs from pull request most recent head 8033101. Consider uploading reports for the commit 8033101 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1587      +/-   ##
==========================================
- Coverage   78.38%   78.24%   -0.15%     
==========================================
  Files          57       57              
  Lines        6597     6608      +11     
==========================================
- Hits         5171     5170       -1     
- Misses       1426     1438      +12     
Files Changed Coverage Δ
buildtest/builders/spack.py 10.27% <0.00%> (-0.60%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @Mariamajib this looks good. I will merge this in

@shahzebsiddiqui shahzebsiddiqui merged commit e8f5548 into buildtesters:devel Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add support to deactivate spack environments

2 participants