Skip to content

Added support for "spack load" in spack schema#1569

Merged
shahzebsiddiqui merged 23 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch
Aug 9, 2023
Merged

Added support for "spack load" in spack schema#1569
shahzebsiddiqui merged 23 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch

Conversation

@Mariamajib
Copy link
Collaborator

@Mariamajib Mariamajib commented Jul 20, 2023 •
edited
Loading

@Mariamajib Mariamajib changed the title added spack load to buildtest/buildtest/schemas/spack.schema.json Added support for load in spack schema Jul 20, 2023
@Mariamajib Mariamajib self-assigned this Jul 20, 2023
@Mariamajib Mariamajib linked an issue Jul 20, 2023 that may be closed by this pull request
[FEATURE]: Ability to load specs in spack schema #1533
Closed
7 tasks
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (c828d11) 78.38% compared to head (b2e3eeb) 78.27%.
Report is 12 commits behind head on devel.

❗ Current head b2e3eeb differs from pull request most recent head f5ec3e6. Consider uploading reports for the commit f5ec3e6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1569      +/-   ##
==========================================
- Coverage   78.38%   78.27%   -0.12%     
==========================================
  Files          57       56       -1     
  Lines        6597     6575      -22     
==========================================
- Hits         5171     5146      -25     
- Misses       1426     1429       +3
Files Changed Coverage Δ
buildtest/builders/spack.py 10.42% <0.00%> (-0.45%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mariamajib Mariamajib changed the title Added support for load in spack schema Added support to load packages in spack schema Jul 20, 2023
@Mariamajib Mariamajib changed the title Added support to load packages in spack schema Added support to spack load in spack schema Jul 20, 2023
@Mariamajib Mariamajib changed the title Added support to spack load in spack schema Added support for "spack load" in spack schema Jul 20, 2023
@Mariamajib Mariamajib requested review from shahzebsiddiqui and removed request for shahzebsiddiqui July 25, 2023 16:44
@Mariamajib Mariamajib marked this pull request as ready for review July 25, 2023 16:45
@Mariamajib Mariamajib marked this pull request as draft July 25, 2023 16:47
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 27, 2023
@Mariamajib Mariamajib marked this pull request as ready for review July 27, 2023 13:12
@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Jul 31, 2023

@Mariamajib so i would like you to add the documentation.

Please add your two commands buildtest build and buildtest inspect query in this section inorder to autogenerate the two examples

buildtest/buildtest/tools/docs.py

Lines 69 to 94 in eeae018

commands_to_run = {
f"{build_dir}/install_specs.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/install_specs.yml",
f"{build_dir}/env_install.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/env_install.yml",
f"{build_dir}/env_create_directory.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/env_create_directory.yml",
f"{build_dir}/env_create_manifest.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/env_create_manifest.yml",
f"{build_dir}/remove_environment_example.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/remove_environment_example.yml",
f"{build_dir}/pre_post_cmds.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/pre_post_cmds.yml",
f"{build_dir}/mirror_example.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/mirror_example.yml",
f"{build_dir}/spack_test.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/spack_test.yml",
f"{build_dir}/spack_test_specs.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/spack_test_specs.yml",
f"{build_dir}/spack_sbatch.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/spack_sbatch.yml",
f"{build_dir}/e4s_testsuite_mpich.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/e4s_testsuite_mpich.yml",
f"{build_dir}/clone_spack.txt": f"buildtest build -b {SPACK_EXAMPLE_DIR}/clone_spack.yml",
f"{inspect_dir}/install_specs.txt": "buildtest inspect query -o --testpath install_specs_example",
f"{inspect_dir}/env_install.txt": "buildtest inspect query --testpath install_in_spack_env",
f"{inspect_dir}/env_create_directory.txt": "buildtest inspect query -o --testpath spack_env_directory",
f"{inspect_dir}/env_create_manifest.txt": "buildtest inspect query -o --testpath spack_env_create_from_manifest",
f"{inspect_dir}/remove_environment_example.txt": "buildtest inspect query --testpath remove_environment_automatically remove_environment_explicit",
f"{inspect_dir}/pre_post_cmds.txt": "buildtest inspect query -o --testpath run_pre_post_commands",
f"{inspect_dir}/mirror_example.txt": "buildtest inspect query -o --testpath add_mirror add_mirror_in_spack_env",
f"{inspect_dir}/spack_test.txt": "buildtest inspect query -o --testpath spack_test_m4",
f"{inspect_dir}/spack_test_specs.txt": "buildtest inspect query -o --testpath spack_test_results_specs_format",
f"{inspect_dir}/spack_sbatch.txt": "buildtest inspect query --testpath spack_sbatch_example",
f"{inspect_dir}/clone_spack.txt": "buildtest inspect query -o --testpath clone_spack_automatically clone_spack_and_specify_root",
f"{inspect_dir}/e4s_testsuite_mpich.txt": "buildtest inspect query -o -e --testpath mpich_e4s_testsuite",
}

Next please get into the container the command to run is docker run -it -v $BUILDTEST_ROOT:/home/spack/buildtest ghcr.io/buildtesters/buildtest_spack:latest but you should check https://buildtest.readthedocs.io/en/devel/contributing/build_documentation.html#generating-documentation-examples-for-buildtest-tutorial

Next run buildtest tutorial-examples and then only add the two files that are relevant for the PR. This command will autogenerate the entire documentation so dont add all the files.

Once the files are generated please write the documentation

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 8, 2023
Mariamajib and others added 5 commits August 8, 2023 16:15
@Mariamajib
updated style check
e83bc69
@Mariamajib
updated style check
1cf6c25
@Mariamajib
updated spack.rst
0c959b2
@Mariamajib
updated spack.rst
4ec2d19
@shahzebsiddiqui
update documentation for spack load example
f5ec3e6 
remove the output from the `buildtest inspect query` command when showing results for the spack load example
@shahzebsiddiqui shahzebsiddiqui merged commit f4ecbfa into buildtesters:devel Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui left review comments

@szuananwar szuananwar Awaiting requested review from szuananwar

Assignees

@Mariamajib Mariamajib

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Ability to load specs in spack schema

2 participants

@Mariamajib @shahzebsiddiqui