Modified behavior of --help/-h and added commands -H/--help--all#1568
Merged
shahzebsiddiqui merged 13 commits intobuildtesters:develfrom Jul 27, 2023
Merged
Modified behavior of --help/-h and added commands -H/--help--all#1568shahzebsiddiqui merged 13 commits intobuildtesters:develfrom
shahzebsiddiqui merged 13 commits intobuildtesters:develfrom
Conversation
Modified the behavior of --help and added new command --help--all
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1568 +/- ##
==========================================
- Coverage 78.39% 78.34% -0.06%
==========================================
Files 56 56
Lines 6558 6569 +11
==========================================
+ Hits 5141 5146 +5
- Misses 1417 1423 +6
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Should I add coverage for the init file? |
wrote the method to avoid having redundant if/else statement when trying to display hidden help messages
Collaborator
Author
|
Just pushed a commit based on the feedback from the review. |
help_all method is only called once in get_parser method.
changes based on feedback
shahzebsiddiqui
approved these changes
Jul 27, 2023
Member
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
@Mendi03 this looks good. Thanks for adding support for this feature!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1453
--help/-h. Some subcommands and there respective help messages were removed since they are only used for development purposes, it will now only show less subcommands.--help-all/-H, which will now do what--helpdid before. It will show all subcommands and their help message.Output of
-hand--help:Output of
-Hand--help-all