Skip to content

Add Coverage to check runtime status#1564

Merged
shahzebsiddiqui merged 3 commits intobuildtesters:develfrom
szuananwar:test_runtime_check
Jul 19, 2023
Merged

Add Coverage to check runtime status#1564
shahzebsiddiqui merged 3 commits intobuildtesters:develfrom
szuananwar:test_runtime_check

Conversation

@szuananwar
Copy link
Collaborator

This test will add coverage in the runtime status check for the case when only max runtime is specified and for the case when both max and min runtime are specified in the buildspec.

@szuananwar szuananwar linked an issue Jul 18, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 51.28% and project coverage change: +0.53 🎉

Comparison is base (2d37b2a) 77.86% compared to head (d256828) 78.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1564      +/-   ##
==========================================
+ Coverage   77.86%   78.39%   +0.53%     
==========================================
  Files          57       56       -1     
  Lines        6621     6558      -63     
==========================================
- Hits         5155     5141      -14     
+ Misses       1466     1417      -49     
Impacted Files Coverage Δ
buildtest/cli/__init__.py 100.00% <ø> (ø)
buildtest/cli/config.py 86.76% <ø> (ø)
buildtest/executors/cobalt.py 21.51% <0.00%> (-0.60%) ⬇️
buildtest/executors/lsf.py 19.28% <0.00%> (-0.72%) ⬇️
buildtest/executors/pbs.py 21.43% <0.00%> (-0.49%) ⬇️
buildtest/executors/slurm.py 20.51% <0.00%> (-0.74%) ⬇️
buildtest/cli/report.py 96.02% <88.24%> (+6.13%) ⬆️
buildtest/builders/base.py 89.46% <100.00%> (+0.13%) ⬆️
buildtest/executors/local.py 98.00% <100.00%> (+3.77%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@szuananwar szuananwar self-assigned this Jul 19, 2023
@shahzebsiddiqui shahzebsiddiqui merged commit 260a35c into buildtesters:devel Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add coverage for runtime status check.

2 participants