Removed buildtest build option --disable-executor-check #1541
Removed buildtest build option --disable-executor-check #1541shahzebsiddiqui merged 24 commits intobuildtesters:develfrom
Conversation
…in buildtest/main.py
szuananwar
left a comment
There was a problem hiding this comment.
@Mariamajib Please see my comments.
|
We will need to work on documenting these changes partner @Mariamajib! |
|
No this doesn't need to be documented we are removing this feature |
|
@shahzebsiddiqui I meant remove it from the document too: https://buildtest.readthedocs.io/en/devel/command.html#extra |
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
please make this one change you should be all set
This is auto-generated so it will be removed, you could probably see it in the generated docs but right now they are not passing |
|
@Mariamajib please fix the CI checks and documentation is not building |
|
@Mariamajib i am seeing issues with regression test can you please take a look. Also documentation is not building |
|
I did a quick search https://github.com/search?q=repo%3Abuildtesters%2Fbuildtest%20validate_executors&type=code and found a few more references to where we set |
|
@shahzebsiddiqui Thank you. I will fix it! |
…norder to build a list of valid executors. This was not invoked which caused regression test to fail because buildspecs were not validated properly
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1541 +/- ##
==========================================
- Coverage 77.88% 77.86% -0.02%
==========================================
Files 57 57
Lines 6623 6621 -2
==========================================
- Hits 5158 5155 -3
- Misses 1465 1466 +1
☔ View full report in Codecov by Sentry. |
2. Made a comment in test_builders.py about a bug fixed 3. Moved test_stats.py from ../tests/cli to tests
No description provided.