Add buildtest commands option by braeeast2001 · Pull Request #1540 · buildtesters/buildtest

braeeast2001 · 2023-07-11T20:05:08Z

Create a feature to show an output of Buildtest commands, by doing the following:

1. Adding a command option in buildtest/cli/init.py

2. Adding to bash completion script -

3. Adding implementation; creating a module buildtest/cli/commands.py

4. Adding a regression test; creating a separate file in tests/cli/test_commands.py

…dtest into Brae'zah_Patch

codecov · 2023-07-11T21:52:43Z

Codecov Report

Patch coverage: 72.73% and project coverage change: +0.02% 🎉

Comparison is base (eedb821) 78.36% compared to head (8abc678) 78.38%.
Report is 36 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #1540      +/-   ##
==========================================
+ Coverage   78.36%   78.38%   +0.02%     
==========================================
  Files          56       57       +1     
  Lines        6577     6583       +6     
==========================================
+ Hits         5154     5160       +6     
  Misses       1423     1423

Files Changed	Coverage Δ
buildtest/cli/__init__.py	`98.20% <64.71%> (+0.01%)`	⬆️
buildtest/cli/commands.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

braeeast2001 · 2023-07-12T14:44:27Z

@shahzebsiddiqui When I run the command "buildtest help commands" the output I sent to you in Slack appears. Is this what I am supposed to be fixing?

Create commands_subparser and 'commands' to the "COMMANDS List"

shahzebsiddiqui · 2023-07-13T16:10:55Z

@shahzebsiddiqui When I run the command "buildtest help commands" the output I sent to you in Slack appears. Is this what I am supposed to be fixing?

No that not what i asked for i want you to add a command buildtest commands that will display all the subcommands. See #1509 (comment)

Add "else if" statement to main.py Add to commads.py file

buildtest/cli/commands.py

Removed table; Pritning raw list

shahzebsiddiqui · 2023-07-18T19:12:10Z

@braeeast2001 i fixed your PR and rewrote this to be easier to understand. Please add the regression test and we can merge this in.

Lets not document this feature for now its not necessary.

Add regression test

…dtest into Brae'zah_Patch

tests/cli/test_commands.py

buildtest/cli/commands.py

Remove unused items and rename multiple items

shahzebsiddiqui · 2023-07-24T18:44:00Z

@braeeast2001 can please look at the CI checks and fix them

shahzebsiddiqui · 2023-07-26T00:09:06Z

@braeeast2001 can you please black your code. Look at the style check it reports 3files need formatting.

Just run buildtest style -a

bash_completion.sh

buildtest/cli/commands.py

shahzebsiddiqui · 2023-07-26T00:15:08Z

@braeeast2001 can you please recreate your python environment and reinstall buildtest it looks like your black and isort are not using the configuration specified from pyproject.toml

This might address some formatting issues you are facing.

Please delete your existing python virtual environment.

You should consider using pipenv it will simplify managing virtual environment

Alphabetize lines 459-461

…dtest into Brae'zah_Patch

bash_completion.sh

buildtest/cli/commands.py

black buildtest tests

…dtest into Brae'zah_Patch

buildtest/cli/commands.py

braeeast2001 · 2023-07-31T20:29:17Z

Change completed, ready to merge.

shahzebsiddiqui · 2023-08-01T19:49:45Z

@braeeast2001 can you please resolve the conflict

Matched updates from PR buildtesters#1578

shahzebsiddiqui

thanks @braeeast2001 this looks good.

braeeast2001 added 3 commits July 11, 2023 14:50

Update regex_on_invalids.yml

8ed5e94

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

c22588d

…dtest into Brae'zah_Patch

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

a674a61

…dtest into Brae'zah_Patch

braeeast2001 self-assigned this Jul 11, 2023

pull-request-size bot added the size/XS label Jul 11, 2023

braeeast2001 linked an issue Jul 11, 2023 that may be closed by this pull request

[FEATURE]: buildtest commands #1509

Closed

7 tasks

Create recommended files

38d372f

Update __int__.py and bash_completion.sh

c0e9907

Create commands_subparser and 'commands' to the "COMMANDS List"

pull-request-size bot added size/S and removed size/XS labels Jul 13, 2023

braeeast2001 marked this pull request as ready for review July 13, 2023 15:54

braeeast2001 requested a review from shahzebsiddiqui July 13, 2023 15:59

braeeast2001 marked this pull request as draft July 13, 2023 16:18

braeeast2001 marked this pull request as ready for review July 15, 2023 00:31

Update files

ae8dfd1

Add "else if" statement to main.py Add to commads.py file

pull-request-size bot added size/M and removed size/S labels Jul 17, 2023

shahzebsiddiqui reviewed Jul 17, 2023

View reviewed changes

buildtest/cli/commands.py Outdated Show resolved Hide resolved

Update commands.py

e755449

Removed table; Pritning raw list

pull-request-size bot added size/S and removed size/M labels Jul 17, 2023

rewrite method implemention for 'buildtest commands'

d74248a

pull-request-size bot added size/M and removed size/S labels Jul 18, 2023

braeeast2001 added 2 commits July 19, 2023 10:44

Update test_commands.py

75e2dc2

Add regression test

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

ebb409b

…dtest into Brae'zah_Patch

shahzebsiddiqui reviewed Jul 21, 2023

View reviewed changes

tests/cli/test_commands.py Outdated Show resolved Hide resolved

Update test_commands.py

4533930

shahzebsiddiqui reviewed Jul 21, 2023

View reviewed changes

tests/cli/test_commands.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 21, 2023

View reviewed changes

buildtest/cli/commands.py Outdated Show resolved Hide resolved

braeeast2001 added 2 commits July 21, 2023 15:26

Update __innt__.py, commands.py, test_commands.py

83d505d

Remove unused items and rename multiple items

Update test_commands.py

ea458f7

Update main.py

d599bf5

shahzebsiddiqui reviewed Jul 26, 2023

View reviewed changes

bash_completion.sh Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 26, 2023

View reviewed changes

bash_completion.sh Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 26, 2023

View reviewed changes

buildtest/cli/commands.py Outdated Show resolved Hide resolved

braeeast2001 and others added 3 commits July 26, 2023 08:46

Update bash_completion.sh

8a83c35

Alphabetize lines 459-461

Update commands.py

7202221

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

491b78d

…dtest into Brae'zah_Patch

shahzebsiddiqui reviewed Jul 27, 2023

View reviewed changes

bash_completion.sh Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 27, 2023

View reviewed changes

buildtest/cli/commands.py Outdated Show resolved Hide resolved

braeeast2001 and others added 3 commits July 27, 2023 10:28

Update bash_completion.sh

0dd6d7b

Style check (black)

b6f319f

black buildtest tests

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

001cbd3

…dtest into Brae'zah_Patch

shahzebsiddiqui reviewed Jul 31, 2023

View reviewed changes

buildtest/cli/commands.py Outdated Show resolved Hide resolved

braeeast2001 and others added 2 commits July 31, 2023 13:20

Update commands.py

538c59f

Merge branch 'devel' into Brae'zah_Patch

6640fca

braeeast2001 added 2 commits August 1, 2023 15:01

Merge branch 'devel' into Brae'zah_Patch

6a96e4a

Update bash_completion.sh

8abc678

Matched updates from PR buildtesters#1578

shahzebsiddiqui approved these changes Aug 1, 2023

View reviewed changes

shahzebsiddiqui merged commit 701af0a into buildtesters:devel Aug 1, 2023

Uh oh!

Conversation

braeeast2001 commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

braeeast2001 commented Jul 12, 2023

Uh oh!

shahzebsiddiqui commented Jul 13, 2023

Uh oh!

Uh oh!

shahzebsiddiqui commented Jul 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahzebsiddiqui commented Jul 24, 2023

Uh oh!

shahzebsiddiqui commented Jul 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahzebsiddiqui commented Jul 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

braeeast2001 commented Jul 31, 2023

Uh oh!

shahzebsiddiqui commented Aug 1, 2023

Uh oh!

shahzebsiddiqui left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

braeeast2001 commented Jul 11, 2023 •

edited

Loading

codecov bot commented Jul 11, 2023 •

edited

Loading