Buildspec tutorial documentation fix#1538
Merged
shahzebsiddiqui merged 10 commits intobuildtesters:develfrom Jul 14, 2023
Merged
Buildspec tutorial documentation fix#1538shahzebsiddiqui merged 10 commits intobuildtesters:develfrom
shahzebsiddiqui merged 10 commits intobuildtesters:develfrom
Conversation
added build command, highlighted .yml files, and made .txt file match the inspect dropdown
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## devel #1538 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 57 57
Lines 6621 6621
=======================================
Hits 5155 5155
Misses 1466 1466 ☔ View full report in Codecov by Sentry. |
kingxleyy
reviewed
Jul 12, 2023
Collaborator
kingxleyy
left a comment
There was a problem hiding this comment.
it looks good to merge.
Ran command in title to update documentation
Removed the unsupported feature -d all from docs
Comment on lines
+26
to
+43
| State: FAIL | ||
| Returncode: 3 | ||
| Runtime: 44.148474 sec | ||
| Starttime: 2023/07/14 18:45:34 | ||
| Endtime: 2023/07/14 18:46:18 | ||
| Command: bash --norc --noprofile -eo pipefail clone_spack_and_install_zlib_build.sh | ||
| Test Script: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib.sh | ||
| Build Script: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib_build.sh | ||
| Output File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib.out | ||
| Error File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib.err | ||
| Log File: /home/spack/buildtest/var/logs/buildtest_3ufksmr5.log | ||
| ────────────────────────────────────────────────── Output File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib.out ────────────────────────────────────────────────── | ||
| ==> Installing zlib-1.2.13-fp4hlchxmdydxrhdkxh3q3buwtlcrc7k | ||
| ==> No binary for zlib-1.2.13-fp4hlchxmdydxrhdkxh3q3buwtlcrc7k found: installing from source | ||
| ==> Fetching https://mirror.spack.io/_source-cache/archive/b3/b3a24de97a8fdbc835b9833169501030b8977031bcb54b3b3ac13740f846ab30.tar.gz | ||
| ==> No patches needed for zlib | ||
| ==> zlib: Executing phase: 'edit' | ||
| ==> zlib: Executing phase: 'build' | ||
| ==> zlib: Executing phase: 'install' | ||
| ==> zlib: Successfully installed zlib-1.2.13-fp4hlchxmdydxrhdkxh3q3buwtlcrc7k | ||
| Stage: 0.31s. Edit: 0.80s. Build: 1.49s. Install: 0.30s. Total: 2.99s | ||
| [+] /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/stage/spack/opt/spack/linux-ubuntu18.04-x86_64/gcc-7.5.0/zlib-1.2.13-fp4hlchxmdydxrhdkxh3q3buwtlcrc7k | ||
|
|
||
| ─────────────────────────────────────────────────── Test File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/a29977c5/clone_spack_and_install_zlib.sh ──────────────────────────────────────────────────── | ||
| #!/bin/bash | ||
| git clone https://github.com/spack/spack | ||
| source ./spack/share/spack/setup-env.sh | ||
| spack install zlib | ||
| Test Script: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib.sh | ||
| Build Script: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib_build.sh | ||
| Output File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib.out | ||
| Error File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib.err | ||
| Log File: /home/spack/buildtest/var/logs/buildtest_hupirc5k.log | ||
| ────────────────────────────────────────────── Output File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib.out ────────────────────────────────────────────── | ||
|
|
||
| ─────────────────────────────────────────────── Test File: /home/spack/runs/generic.local.bash/install_specs/clone_spack_and_install_zlib/7d2b08e2/clone_spack_and_install_zlib.sh ──────────────────────────────────────────────── | ||
| #!/bin/bash | ||
| git clone https://github.com/spack/spack | ||
| source ./spack/share/spack/setup-env.sh | ||
| spack install zlib |
Member
There was a problem hiding this comment.
okay this is a test failure and i think we need to open an issue and rewrite the way this test is to be done. I think part of the problem is we have a dynamic test since we are using git clone https://github.com/spack/spack to perform an installation of zlib and this test will change depending on state of spack when we run this test. I think a better way for this would be to use a tag branch to force the test to use the same version. @Mendi03 can you please record this as an issue and we can fix this later. For time being let's keep this bug in the docs so we know we have to fix it
Collaborator
Author
There was a problem hiding this comment.
I think this is similar to the issue I talked about in #1518. Should I simply update this issue mentioning that it might be causing the error in docs/buildtest_tutorial_examples/spack/inspect/install_specs.txt? Or do I create a new issue anyways?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1516
closes #1517
Updates to the documentation are the following:
-tcommand to--testpathfor inspect query dropdowns and spack docs script.buildcommand and added highlights to the .yml files in the Specifying Scheduler Directives section under buildtest spack integration