add subsection 'Best Practices when creating Pull Request'#1531
Merged
shahzebsiddiqui merged 4 commits intodevelfrom Jul 12, 2023
Merged
add subsection 'Best Practices when creating Pull Request'#1531shahzebsiddiqui merged 4 commits intodevelfrom
shahzebsiddiqui merged 4 commits intodevelfrom
Conversation
…few sections from General Tips
Collaborator
|
Sure! |
Member
Author
|
you can see the generated docs see https://buildtest--1531.org.readthedocs.build/en/1531/contributing/code_contribution_guide.html#best-practices-when-creating-pull-request |
szuananwar
reviewed
Jul 11, 2023
Member
Author
|
@szuananwar please see now, i addressed your feedback. Thanks for your feedback |
Collaborator
|
Thanks for making all changes, it look good. |
szuananwar
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will create a subsection to document best practices when creating a pull request. I figure this would be helpful for new contributors when contributing changes.
@szuananwar can you please review my proposed changes