Renaming buildtest help to buildtest show#1530
Merged
shahzebsiddiqui merged 10 commits intobuildtesters:develfrom Jul 12, 2023
Merged
Renaming buildtest help to buildtest show#1530shahzebsiddiqui merged 10 commits intobuildtesters:develfrom
shahzebsiddiqui merged 10 commits intobuildtesters:develfrom
Conversation
The buildtest help command is now buildtest show. Example: The output for buildtest help build will now be the output buildtest show build
Renamed "help.py" to "show.py" to leave the word "help" free for new feature
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1530 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 57 57
Lines 6615 6615
=======================================
Hits 5158 5158
Misses 1457 1457
☔ View full report in Codecov by Sentry. |
5 tasks
5 tasks
kingxleyy
reviewed
Jul 11, 2023
Collaborator
kingxleyy
left a comment
There was a problem hiding this comment.
everything looks good to me
Mendi03
commented
Jul 11, 2023
changed the name and instances of the method test_buildtest_help to test_buildtest_show and changed buildtest_help to buildtest_show. Latly, changed file name test_help to test_show.
shahzebsiddiqui
approved these changes
Jul 12, 2023
Member
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
LGTM. Great job @Mendi03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the following updates:
buildtest helptobuildtest showin order to create new purpose forbuildtest helpcommand.buildtest helpwere changed tobuildtest showin the show.py and test_show.py file